[FFmpeg-devel] [PATCH] Fix unaligned fill_rectangle in rv34.c

Michael Niedermayer michaelni
Fri Aug 21 11:57:08 CEST 2009

On Thu, Aug 20, 2009 at 10:33:19AM +0300, Kostya wrote:
> On Thu, Aug 20, 2009 at 09:14:54AM +0200, Reimar D?ffinger wrote:
> > Hello,
> > rv34.c uses fill_rectangle with only 4 bytes alignment, which causes
> > crashes on 64 bit architectures without unaligned read support like
> > Sparc/Solaris.
> > This patch hacks rectangle.h to support this kind of use - this
> > seemed the simplest, even though rather hackish, way to me.
> May I add that it happens when zeroing motion vectors for some
> macroblock, i.e. where there will be non-64bit align for sure.
> Probably better solution would be to disable this code automatically for
> such archs. I don't remember an outcome of my discussion with Mans
> about that though.

I dont know about your discussion with mans, but if i remember correctly
and dont mix this up with some other issue, then at least my conclusion
was that your code is buggy and fails to align the code correctly.
IIRC something about using a random incorrect *_stride but i might

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090821/4a9966d2/attachment.pgp>

More information about the ffmpeg-devel mailing list