[FFmpeg-devel] [PATCH] ensure sub->start_display_time is 0, move offset to pts

Michael Niedermayer michaelni
Fri Aug 21 12:57:18 CEST 2009


On Fri, Aug 21, 2009 at 12:53:17PM +0200, Reimar D?ffinger wrote:
> On Fri, Aug 21, 2009 at 12:41:37PM +0200, Michael Niedermayer wrote:
> > On Thu, Aug 20, 2009 at 08:44:16PM +0200, Reimar D?ffinger wrote:
> > > As in subject. Without this encoding e.g. from xsub to dvdsub fails.
> > 
> > ok if tested
> 
> xsub -> dvdsub in mkv works (at least the timing is not visibly wrong)

good
but shouldt that if() below your code be removed?


> except that the palette gets lost somewhere somehow (but that is obviously unrelated).

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090821/a9cf4f37/attachment.pgp>



More information about the ffmpeg-devel mailing list