[FFmpeg-devel] [PATCH] ensure sub->start_display_time is 0, move offset to pts

Reimar Döffinger Reimar.Doeffinger
Fri Aug 21 13:14:22 CEST 2009


On Fri, Aug 21, 2009 at 12:57:18PM +0200, Michael Niedermayer wrote:
> On Fri, Aug 21, 2009 at 12:53:17PM +0200, Reimar D?ffinger wrote:
> > On Fri, Aug 21, 2009 at 12:41:37PM +0200, Michael Niedermayer wrote:
> > > On Thu, Aug 20, 2009 at 08:44:16PM +0200, Reimar D?ffinger wrote:
> > > > As in subject. Without this encoding e.g. from xsub to dvdsub fails.
> > > 
> > > ok if tested
> > 
> > xsub -> dvdsub in mkv works (at least the timing is not visibly wrong)
> 
> good
> but shouldt that if() below your code be removed?

Well, at least the end_time thing is still necessary, the other one
could/should be removed, but that seems somewhat unrelated (start_time
!= 0 at that code point was just as impossible before this patch as it
is after, so I thought it shouldn't be combined).
And to be honest, I'd like to have some look at the DVB sub stuff before
touching anything.



More information about the ffmpeg-devel mailing list