[FFmpeg-devel] [PATCH] ALS decoder

Thilo Borgmann thilo.borgmann
Tue Aug 25 19:05:10 CEST 2009


Reimar D?ffinger schrieb:
> On Tue, Aug 25, 2009 at 05:38:35PM +0200, Thilo Borgmann wrote:
>>> Though personally I'd suggest expanding the memset+increment
>>> into a bytestream_fill_byte() that does both.
>> If it would be beneficial compared to the other solution, I would
>> rewrite it, but I think it will add some kind of bytestream context or
>> similar overhead for a one-time usage? (Haven't used bytestream yet).
> 
> No, bytestream stuff is just tiny convenience wrappers for stuff like
> AV_RL32+pointer increment, no extra context or anything at all.
I just had a look at them... nice macros but I think not applicable
anymore, since the applicable loop in the middle code block has been
simplified like you suggested earlier (done in rev 10, not rev9).

Wrong?

-Thilo



More information about the ffmpeg-devel mailing list