[FFmpeg-devel] [PATCH] ALS decoder
Tue Aug 25 19:32:58 CEST 2009
On Tue, Aug 25, 2009 at 07:05:10PM +0200, Thilo Borgmann wrote:
> Reimar D?ffinger schrieb:
> > On Tue, Aug 25, 2009 at 05:38:35PM +0200, Thilo Borgmann wrote:
> >>> Though personally I'd suggest expanding the memset+increment
> >>> into a bytestream_fill_byte() that does both.
> >> If it would be beneficial compared to the other solution, I would
> >> rewrite it, but I think it will add some kind of bytestream context or
> >> similar overhead for a one-time usage? (Haven't used bytestream yet).
> > No, bytestream stuff is just tiny convenience wrappers for stuff like
> > AV_RL32+pointer increment, no extra context or anything at all.
> I just had a look at them... nice macros but I think not applicable
> anymore, since the applicable loop in the middle code block has been
> simplified like you suggested earlier (done in rev 10, not rev9).
Well, it's not the first time that a bytestream_fill_byte or something
like that would have been useful, that's why I mentioned it.
It would still combine the memset+increment into a single function call.
Obviously not something I'd insist on, only mentioned it because as I
said I remember another case where it would have (very slightly)
simplified the code.
More information about the ffmpeg-devel