[FFmpeg-devel] [PATCH][RFC] add a list of generic tag names

Baptiste Coudurier baptiste.coudurier
Wed Dec 16 21:52:46 CET 2009


On 12/16/2009 12:36 PM, Michael Niedermayer wrote:
> On Tue, Dec 15, 2009 at 09:55:36PM +0100, Anton Khirnov wrote:
>> On Tue, Dec 15, 2009 at 03:39:02PM +0100, Michael Niedermayer wrote:
>>> Well, you probably are correct, it just felt more correct when i read
>>> the change from ffmbc.
>>> If you send a patch that reverts it ill approve it.
>> OTOH artist is much more widely used in both containers and other apps.
>> I'd say we add a compatibility hack to av_metadata_conv() that will set
>> author from artist and vice versa, which will be removed on next major
>> bump.
> fine with me as well

Yes, I also believe artist is much more widely used, that's why I 
changed in the first place.

Thanks Anton for the work on this, greatly appreciated.

However I have a problem with changing author from artist and vice-versa.
mov has:
     case MKTAG(0xa9,'a','u','t'):
     case MKTAG(0xa9,'A','R','T'): key = "author";    break;

Clearly "ART" should be artist, however "aut" seems very much like 
author to me, and only changing "ART" to artist makes sense.

Waiting for a major bump to update it seems painful to me, especially 
when the cleanup is really useful. I believe a minor bump should be 


Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org

More information about the ffmpeg-devel mailing list