[FFmpeg-devel] [PATCH][RFC] add a list of generic tag names
Wed Dec 16 23:17:15 CET 2009
On Wed, Dec 16, 2009 at 12:52:46PM -0800, Baptiste Coudurier wrote:
> On 12/16/2009 12:36 PM, Michael Niedermayer wrote:
>> On Tue, Dec 15, 2009 at 09:55:36PM +0100, Anton Khirnov wrote:
>>> On Tue, Dec 15, 2009 at 03:39:02PM +0100, Michael Niedermayer wrote:
>>>> Well, you probably are correct, it just felt more correct when i read
>>>> the change from ffmbc.
>>>> If you send a patch that reverts it ill approve it.
>>> OTOH artist is much more widely used in both containers and other apps.
>>> I'd say we add a compatibility hack to av_metadata_conv() that will set
>>> author from artist and vice versa, which will be removed on next major
>> fine with me as well
> Yes, I also believe artist is much more widely used, that's why I changed
> in the first place.
> Thanks Anton for the work on this, greatly appreciated.
> However I have a problem with changing author from artist and vice-versa.
> mov has:
> case MKTAG(0xa9,'a','u','t'):
> case MKTAG(0xa9,'A','R','T'): key = "author"; break;
> Clearly "ART" should be artist, however "aut" seems very much like author
> to me, and only changing "ART" to artist makes sense.
> Waiting for a major bump to update it seems painful to me, especially when
> the cleanup is really useful. I believe a minor bump should be sufficient.
yes iam fine with a minor bump
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Opposition brings concord. Out of discord comes the fairest harmony.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel