[FFmpeg-devel] [PATCH] Some lavf renames

Stefano Sabatini stefano.sabatini-lala
Sat Feb 7 20:57:11 CET 2009

On date Saturday 2009-02-07 14:00:40 +0100, Michael Niedermayer encoded:
> On Sat, Feb 07, 2009 at 09:50:42AM +0100, Stefano Sabatini wrote:
> > This has been discussed before, I think as a rule is best to follow
> > this path:
> > 1) rename + deprecation
> > 2) replacement in the code
> > 3) ifversioning of the old symbol
> > 
> > doing 3) before 2) may result in a break if a major bump happens
> > before 2), well this is not going to happen so from a practical point
> > of view it makes no difference but I think it's more correct.
> > 
> > Anyway if you prefer I'll apply this variant.
> yes i prefer it, iam strongly against spliting patches in a way that
> asks for cruft to be missed
> it is very easy to remove the #if when someone bumps the version, it
> is not easy to notice such unused code if there is no if and no comment
> (gcc will not warn about it because it cant easily find out that it is
>  unused)

I see your point, I'll follow this path the next times.

OK to apply?
FFmpeg = Freak and Free Meaningless Puristic Elitarian Gymnast
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rename-av-alloc-format-context2.patch
Type: text/x-diff
Size: 1875 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090207/20a06add/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: replace-av-alloc-format-context.patch
Type: text/x-diff
Size: 4187 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090207/20a06add/attachment-0001.patch>

More information about the ffmpeg-devel mailing list