[FFmpeg-devel] [PATCH] Some lavf renames
Sun Feb 8 03:38:29 CET 2009
On Sat, Feb 07, 2009 at 08:57:11PM +0100, Stefano Sabatini wrote:
> On date Saturday 2009-02-07 14:00:40 +0100, Michael Niedermayer encoded:
> > On Sat, Feb 07, 2009 at 09:50:42AM +0100, Stefano Sabatini wrote:
> > > This has been discussed before, I think as a rule is best to follow
> > > this path:
> > > 1) rename + deprecation
> > > 2) replacement in the code
> > > 3) ifversioning of the old symbol
> > >
> > > doing 3) before 2) may result in a break if a major bump happens
> > > before 2), well this is not going to happen so from a practical point
> > > of view it makes no difference but I think it's more correct.
> > >
> > > Anyway if you prefer I'll apply this variant.
> > yes i prefer it, iam strongly against spliting patches in a way that
> > asks for cruft to be missed
> > it is very easy to remove the #if when someone bumps the version, it
> > is not easy to notice such unused code if there is no if and no comment
> > (gcc will not warn about it because it cant easily find out that it is
> > unused)
> I see your point, I'll follow this path the next times.
> OK to apply?
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel