[FFmpeg-devel] [PATCH] Store compatible brands in AVFormatContext

[Michael Niedermayer]

On Thu, Feb 26, 2009 at 05:16:55PM +0200, Haim Alon wrote:
> Hi,
> 
> This patch fetches the compatible brands and stores them together with
> the major/minor version in the AVFormatContext structure.
> Regards,
> Haim.

[...]
> Index: libavformat/avformat.h
> ===================================================================
> --- libavformat/avformat.h	(revision 17607)
> +++ libavformat/avformat.h	(working copy)
> @@ -696,6 +696,12 @@
>      struct AVPacketList *packet_buffer_end;
>  
>      AVMetadata *metadata;
> +
> +    #define MAXCTYPES 6
> +    char ftype_mj[5];
> +    int ftype_mi;;
> +    int numCT;
> +    char ftype_ct[MAXCTYPES][5];
>  } AVFormatContext;

this is not acceptable
all fields have to be fully documented first and second need to have
descriptive names. Once that is done it can be reviewed


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090226/13d68895/attachment.pgp>