[FFmpeg-devel] [PATCH] Store compatible brands in AVFormatContext

[Baptiste Coudurier]

On 2/26/2009 8:08 AM, Michael Niedermayer wrote:
> On Thu, Feb 26, 2009 at 05:16:55PM +0200, Haim Alon wrote:
>> Hi,
>>
>> This patch fetches the compatible brands and stores them together with
>> the major/minor version in the AVFormatContext structure.
>> Regards,
>> Haim.
> 
> [...]
>> Index: libavformat/avformat.h
>> ===================================================================
>> --- libavformat/avformat.h	(revision 17607)
>> +++ libavformat/avformat.h	(working copy)
>> @@ -696,6 +696,12 @@
>>      struct AVPacketList *packet_buffer_end;
>>  
>>      AVMetadata *metadata;
>> +
>> +    #define MAXCTYPES 6
>> +    char ftype_mj[5];
>> +    int ftype_mi;;
>> +    int numCT;
>> +    char ftype_ct[MAXCTYPES][5];
>>  } AVFormatContext;
> 
> this is not acceptable
> all fields have to be fully documented first and second need to have
> descriptive names. Once that is done it can be reviewed
> 

Furthermore, coding style of the patch has to match the one currently
used in mov.c

Also, it might be better to use new generic metadata API for this.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org