[FFmpeg-devel] [PATCH]Fix bug in VDPAU h264

Michael Niedermayer michaelni
Sat Jan 10 00:15:14 CET 2009

On Fri, Jan 09, 2009 at 09:00:28AM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> > > While testing a factorisation patch for vdpauvideo.c, I found a 
> > > (reproducible) bug when actually using vdpau h264 decoding: Crash on a test 
> > > video, always on the same position.
> > > Attached patch fixes the crash.
> > >
> > > Please comment, Carl Eugen
> > 
> > Could you explain what is where and why crashing?
> > Its not clear to me from this patch
> Using NVIDIA's patch for mplayer, and latest, unchanged svn for libav*, playing
> an old HDTV sample (that I had not tried before) always crashes at the same
> point without the patch.

but why does it crash?

> Crashes means that one of NVIDIA's VDPAU-specific functions returns with an
> error value that makes MPlayer exit.

which function, which error value?

Iam trying to understand why this patch makes a difference ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090110/2aedabc0/attachment.pgp>

More information about the ffmpeg-devel mailing list