[FFmpeg-devel] [PATCH] Some lavf renames

Diego Biurrun diego
Thu Jan 22 00:39:31 CET 2009


On Wed, Jan 21, 2009 at 03:40:52AM +0100, Michael Niedermayer wrote:
> On Tue, Jan 20, 2009 at 11:40:37PM +0100, Stefano Sabatini wrote:
> > On date Tuesday 2009-01-20 12:09:20 -0800, Baptiste Coudurier encoded:
> > > 
> > > Ramiro Polla wrote:
> > > > 
> > > > Wasn't there some discussion some time ago about renaming a bunch of
> > > > functions? I think if we're going to rename some functions, we might
> > > > as well rename all functions to be consistent and break API only once.
> > > 
> > > Yes, indeed. We will break API during next major dump, this is not going
> > > to happen anytime soon.
> > 
> > I propose also these renames, people can add to the list:
> > 
> > lavc:
> > register_avcodec          -> avcodec_register()
> > 
> > lavf:
> > ff_reduce_index           -> av_reduce_index
> > av_register_input_format  -> avformat_register_input
> > av_register_output_format -> avformat_register_output
> > av_iformat_next           -> avformat_next_input
> > av_oformat_next           -> avformat_next_output
> 
> i abstain from voting for a color but must note that you guys should
> also consider that every rename will mean every app that use the function
> needs to be updated, not sure if this justifies this cleanup.
> Maybe it does but if i where maintaining some app i likely would be
> primarely pissed about every rename that i had to deal with ...
> But then its no big deal, if people want it, do the rename ...

I'm generally in favor of the rename, just make sure that you do not
overlook a few renames.

Diego




More information about the ffmpeg-devel mailing list