Ramiro Polla ramiro.polla
Thu Jun 4 20:39:33 CEST 2009


On Thu, Jun 4, 2009 at 1:56 PM, Pavel Pavlov <pavel at summit-tech.ca> wrote:
>> -----Original Message-----
>> Please create your patches from the root of the source tree
>> and do not split them file by file, this makes them unwieldy.
> All the files that I sent so far contained more changes related to icl
> compilation. So, in order to sent what I have sent, I had to take base
> version,
> compare it with my modified version, remove all other changes and create
> diff
> for only DECLARE_ALIGNED changes.
> Then while forking on some other stuff I noticed more files for which I
> could
> create similar trvial diffs, so I did it and sent all of them.

We prefer patches made with svn diff from the root directory, so they
can be applied with patch -p0 < blah. I for example keep one clean svn
tree just for the purpose of creating diffs if they're part of some
big changes, and it really helps us out in applying & reviewing

> Let me know if what I have sent is unusable so I wouldn't waste my and
> others' time...

Your patches are welcome, but they'll be more welcome after a few
minor tweaks (it's just standard procedure around here).

Ramiro Polla

More information about the ffmpeg-devel mailing list