[FFmpeg-devel] [PATCH] make packet_size in AVFormatContext unsigned

Ronald S. Bultje rsbultje
Mon Jun 15 23:24:37 CEST 2009


On Mon, Jun 15, 2009 at 4:39 PM, Ronald S. Bultje<rsbultje at gmail.com> wrote:
> On Mon, Jun 15, 2009 at 4:10 PM, Michael Niedermayer<michaelni at gmx.at> wrote:
>> the patch is changing a field to unsiged without you explaining why

Oh right, I forgot the "why": to move ASF's packet_size value into
AVFormatContext, it needs to be unsigned. You requested that, since
ASFContext->packet_size is unsigned, but AVFormatcontext->.. is
signed, therefore moving the value from one to the other is a
potential security risk. We both then agreed it was silly that
AVFormatcontext->.. was signed anyway, since any value <0 is
meaningless, and thus here's my attempt to make it unsigned.


More information about the ffmpeg-devel mailing list