[FFmpeg-devel] [PATCH] make packet_size in AVFormatContext unsigned

Michael Niedermayer michaelni
Mon Jun 15 23:49:17 CEST 2009

On Mon, Jun 15, 2009 at 05:24:37PM -0400, Ronald S. Bultje wrote:
> Hi.
> On Mon, Jun 15, 2009 at 4:39 PM, Ronald S. Bultje<rsbultje at gmail.com> wrote:
> > On Mon, Jun 15, 2009 at 4:10 PM, Michael Niedermayer<michaelni at gmx.at> wrote:
> >> the patch is changing a field to unsiged without you explaining why
> Oh right, I forgot the "why": to move ASF's packet_size value into
> AVFormatContext, it needs to be unsigned. You requested that, since
> ASFContext->packet_size is unsigned, but AVFormatcontext->.. is
> signed, therefore moving the value from one to the other is a
> potential security risk. We both then agreed it was silly that
> AVFormatcontext->.. was signed anyway, since any value <0 is
> meaningless, and thus here's my attempt to make it unsigned.

yes it of coure should be unsigned but i need to check all uses and i 
want to do it just once not repeatly point at bugs it introduces
and you say it does introduce a bug if i understood you correctly ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090615/c53c10db/attachment.pgp>

More information about the ffmpeg-devel mailing list