[FFmpeg-devel] [PATCH] Implement av_find_pix_fmt_descriptor* functions

Stefano Sabatini stefano.sabatini-lala
Sun Mar 22 01:47:17 CET 2009


Hi all.

I'm not sure if is better:
av_find_pix_fmt_descriptor()
av_find_pix_fmt_descriptor_by_name()

which is similar to:
avcodec_find_decoder()
avcodec_find_decoder_by_name()

or
av_get_pix_fmt_descriptor()
av_get_pix_fmt_descriptor_by_name()

which is more similar to:
avcodec_get_pix_fmt()

I think "get" is more appropriate for the first case
(av_get_pix_fmt_descriptor) since we don't have to execute a search
but just pickup the pixdesc from the internal array, while "find"
looks more appropriate in the second case.

Anyway I don't have a strong opinion, so I'd like to hear your
opinion.

As for the little test I'll drop it when committing.

Regards.
-- 
FFmpeg = Faboulous and Faithful Martial Portable Esoteric Gospel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-pixdesc-const.patch
Type: text/x-diff
Size: 735 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090322/a296b862/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: define-find-pix-fmt-descriptor.patch
Type: text/x-diff
Size: 1341 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090322/a296b862/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: define-find-pix-fmt-descriptor-by-name.patch
Type: text/x-diff
Size: 1743 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090322/a296b862/attachment-0002.patch>



More information about the ffmpeg-devel mailing list