[FFmpeg-devel] [PATCH] TwinVQ decoder

Michael Niedermayer michaelni
Wed May 6 19:56:26 CEST 2009

On Wed, May 06, 2009 at 05:09:50PM +0200, Vitor Sessak wrote:
> Vitor Sessak wrote:
>> Hi,
>> I'm running out of ideas on how to improve this code, so I'm submitting it 
>> for review. Among the things I'm not 100% happy with is the windowing mess 
>> and the set_interleave_table_* code duplication. Any suggestion is 
>> welcome.
>> About using dsputils->vector_fmul, it gets two parameters (one for 
>> input/output and other for the window), and I need one that gets three...
>> Finally, it would be very practical to start the review by the tables 
>> since they are so big that every time I send this patch the message need 
>> moderator approval...
> Ping?
> New version attached...
> /**
>  * Parameters and tables that are different for each frame type
>  */
> typedef struct {
>     uint8_t         sub;      ///< Number subblocks in each frame
>     const uint16_t *crb_tbl;
>     uint8_t         n_crb;
>     const float    *fw_cb;
>     uint8_t         fw_n_div;
>     uint8_t         fw_n_bit;
>     const float    *cb0;
>     const float    *cb1;
>     uint8_t         cb_len_read;
> } FrameMode;

All the fields should have comments or better names
this applies to more than this struct ...

also you could post future patches without the tables

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090506/2fb454f6/attachment.pgp>

More information about the ffmpeg-devel mailing list