[FFmpeg-devel] [PATCH] TwinVQ decoder

Vitor Sessak vitor1001
Mon May 18 18:32:55 CEST 2009

Michael Niedermayer wrote:
> On Wed, May 06, 2009 at 05:09:50PM +0200, Vitor Sessak wrote:
>> Vitor Sessak wrote:
>>> Hi,
>>> I'm running out of ideas on how to improve this code, so I'm submitting it 
>>> for review. Among the things I'm not 100% happy with is the windowing mess 
>>> and the set_interleave_table_* code duplication. Any suggestion is 
>>> welcome.
>>> About using dsputils->vector_fmul, it gets two parameters (one for 
>>> input/output and other for the window), and I need one that gets three...
>>> Finally, it would be very practical to start the review by the tables 
>>> since they are so big that every time I send this patch the message need 
>>> moderator approval...
>> Ping?
>> New version attached...
> [...]
>> /**
>>  * Parameters and tables that are different for each frame type
>>  */
>> typedef struct {
>>     uint8_t         sub;      ///< Number subblocks in each frame
>>     const uint16_t *crb_tbl;
>>     uint8_t         n_crb;
>>     const float    *fw_cb;
>>     uint8_t         fw_n_div;
>>     uint8_t         fw_n_bit;
>>     const float    *cb0;
>>     const float    *cb1;
>>     uint8_t         cb_len_read;
>> } FrameMode;
> All the fields should have comments or better names
> this applies to more than this struct ...

Should be better now. Also taken in consideration Diego's comments...

-------------- next part --------------
A non-text attachment was scrubbed...
Name: twinvq.c
Type: text/x-csrc
Size: 34396 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090518/8a02189b/attachment.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: twinvq_data.h
Type: text/x-chdr
Size: 12740 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090518/8a02189b/attachment.h>

More information about the ffmpeg-devel mailing list