[FFmpeg-devel] [PATCH] Add DPX decoder rev-6

Jimmy Christensen jimmy
Mon May 11 07:40:14 CEST 2009


On 2009-05-11 07:37, Diego Biurrun wrote:
> On Mon, May 11, 2009 at 07:11:02AM +0200, Jimmy Christensen wrote:
>> On 2009-05-08 16:10, Diego Biurrun wrote:
>>> On Thu, May 07, 2009 at 10:02:08AM +0200, Jimmy Christensen wrote:
>>>> On 2009-05-06 14:27, Jimmy Christensen wrote:
>>>
>>> Please trim your quotes.
>>
>> Done and will do.
>
> Thanks.
>
>>>> --- libavcodec/dpx.c	(revision 0)
>>>> +++ libavcodec/dpx.c	(revision 0)
>>>> @@ -0,0 +1,166 @@
>>>> +    const uint8_t *headerBuffer = avpkt->data;
>>>> +    const uint8_t *buf = avpkt->data;
>>>> +    int buf_size = avpkt->size;
>>>
>>> Once more with feeling: Align columns where appropriate.  Do you intend
>>> to continue to ignore this comment?
>>
>> Not sure what you mean. Something like this?
>>
>>> +    const uint8_t *headerBuffer = avpkt->data;
>>> +    const uint8_t *buf          = avpkt->data;
>>> +    int buf_size                = avpkt->size;
>
> Yes.
>
> If you don't understand a review comment, ask for clarification,
> don't just ignore it.
>
> Diego

I think I misunderstood the comment and thought you meant alignment in 
the email.

Anyway here's a new patch which works with latest SVN. A new codec was 
added since my last checkout.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpegDPX-rev6.diff
Type: text/x-patch
Size: 8445 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090511/d450e958/attachment.bin>



More information about the ffmpeg-devel mailing list