[FFmpeg-devel] [PATCH 3/5] Subroutine to copy an AAC Program Config Element (PCE)

[Diego Biurrun]

On Wed, May 13, 2009 at 01:26:17AM -0400, Alex Converse wrote:
> --- /dev/null
> +++ b/libavcodec/aac_copypce.c
> @@ -0,0 +1,59 @@
> +/*
> + * copyright (c) 2009 Alex Converse <alex.converse at gmail.com>

Please add a one line description what this file file is.

> +#include "libavcodec/put_bits.h"
> +#include "libavcodec/get_bits.h"
> +#include "libavcodec/aac_copypce.h"

Drop the directory prefix, it's unnecessary.

> +    for (bits = five_bit_ch*5+four_bit_ch*4; bits > 16; bits -= 16) {
> +        copy_bits(pb, gb, 16);
> +    }

pointless {}

> --- /dev/null
> +++ b/libavcodec/aac_copypce.h
> @@ -0,0 +1,27 @@
> +/*
> + * copyright (c) 2009 Alex Converse <alex.converse at gmail.com>

see above

> +#include "libavcodec/put_bits.h"
> +#include "libavcodec/get_bits.h"

see above

Multiple inclusion guards are missing from the header file.

Diego