[FFmpeg-devel] [PATCH 3/5] Subroutine to copy an AAC Program Config Element (PCE)

Alex Converse alex.converse
Wed May 13 07:50:47 CEST 2009


On Wed, May 13, 2009 at 1:31 AM, Diego Biurrun <diego at biurrun.de> wrote:
> On Wed, May 13, 2009 at 01:26:17AM -0400, Alex Converse wrote:
>> --- /dev/null
>> +++ b/libavcodec/aac_copypce.c
>> @@ -0,0 +1,59 @@
>> +/*
>> + * copyright (c) 2009 Alex Converse <alex.converse at gmail.com>
>
> Please add a one line description what this file file is.
>

fixed

>> +#include "libavcodec/put_bits.h"
>> +#include "libavcodec/get_bits.h"
>> +#include "libavcodec/aac_copypce.h"
>
> Drop the directory prefix, it's unnecessary.
>

fixed

>> + ? ?for (bits = five_bit_ch*5+four_bit_ch*4; bits > 16; bits -= 16) {
>> + ? ? ? ?copy_bits(pb, gb, 16);
>> + ? ?}
>
> pointless {}
>

fixed

>> --- /dev/null
>> +++ b/libavcodec/aac_copypce.h
>> @@ -0,0 +1,27 @@
>> +/*
>> + * copyright (c) 2009 Alex Converse <alex.converse at gmail.com>
>
> see above
>

see above

>> +#include "libavcodec/put_bits.h"
>> +#include "libavcodec/get_bits.h"
>
> see above
>

see above

> Multiple inclusion guards are missing from the header file.
>

fixed

[...]

--Alex
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Subroutine-to-copy-an-AAC-Program-Config-Element-PCE.patch
Type: text/x-patch
Size: 3905 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090513/a42c388e/attachment.bin>



More information about the ffmpeg-devel mailing list