[FFmpeg-devel] [PATCH] libavfilter-soc: Make the overlay filter able to align to opposite edges

Stefano Sabatini stefano.sabatini-lala
Wed May 13 23:56:19 CEST 2009

On date Tuesday 2009-05-12 20:16:09 +0200, Vitor Sessak encoded:
> Martin Storsj? wrote:
>> On Tue, 12 May 2009, Martin Storsj? wrote:
>>> Thanks! This looks like a really good idea. A new patch is attached, 
>>> which uses ff_eval2 to parse the x and y offset parameters. This 
>>> looks like a much more flexible approach, giving the user possibility 
>>> to align the overlay in much more ways.
>> An updated patch is attached, rebased onto the latest libavfilter. A 
>> few other minor things are cleaned up, too.

Please also add documentation to vfilters.texi.

> Fine by me, but maybe Stefano might want to comment, since he's been  
> working with passing parameters to filters.

Looks fine to me, but I'm not particularly fond of positional
parameter, if the av_set_options_string() will be applied we could use
the x=...:y=... syntax, but we can eventually add it later.

I'm not sure if it makes sense at this point to also support some
alignment flags:

since the new syntax is expressive enough, maybe it would be anyway a
nice UI bonus (with a slightly price in term of complexity).

Regards and thanks for all your patches Martin :).
FFmpeg = Fiendish & Fundamental Miracolous Pitiless Exuberant Guru

More information about the ffmpeg-devel mailing list