[FFmpeg-devel] [PATCH] libavfilter-soc: Make the overlay filter able to align to opposite edges

Martin Storsjö martin
Thu May 14 00:18:41 CEST 2009

On Wed, 13 May 2009, Stefano Sabatini wrote:

> Please also add documentation to vfilters.texi.


> > Fine by me, but maybe Stefano might want to comment, since he's been  
> > working with passing parameters to filters.
> Looks fine to me, but I'm not particularly fond of positional
> parameter, if the av_set_options_string() will be applied we could use
> the x=...:y=... syntax, but we can eventually add it later.

Yeah, that's probably a good second step. This step doesn't change the
existing parameter format, it just extends it :-) That'd be a good thing 
to consider when av_set_options_string() is fully merged, though.

> I'm not sure if it makes sense at this point to also support some
> alignment flags:
> align=top+right
> since the new syntax is expressive enough, maybe it would be anyway a
> nice UI bonus (with a slightly price in term of complexity).

Perhaps it'd be a bonus, but I don't feel it's necessary at the moment, 
since this is so much more expressive (in addition to aligning to the 
other edges, it also makes centering easy, etc.). At least not necessary 
for this first patch. :-)

// Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libavfilter-soc-overlay-param-eval.patch
Type: text/x-diff
Size: 4039 bytes
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090514/47893d25/attachment.patch>

More information about the ffmpeg-devel mailing list