[FFmpeg-devel] [PATCH] mpeg12: fix non-standard use of "extern inline"

Måns Rullgård mans
Sat May 16 20:09:57 CEST 2009

Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:

> On Sat, 2009-05-16 at 14:16 +0100, Mans Rullgard wrote:
>> Rename ff_mpeg1_decode_block_intra to mpeg1_decode_block_intra and
>> make it static.  Add ff_mpeg1_decode_block_intra as plain extern
>> function calling mpeg1_decode_block_intra.
> Wouldn't just deleting the "inline" specifier from mpeg12.h be enough?

Then the calls to it in the same file are no longer inlined.

The problem with "extern inline" is that the standard says one thing,
and gcc does another.  We are relying on the gcc behaviour here.  A
strictly conforming C99 compiler will not compile that code.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list