[FFmpeg-devel] [PATCH] mpeg12: fix non-standard use of "extern inline"

Måns Rullgård mans
Sun May 17 15:39:13 CEST 2009


Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:

> On Sun, 2009-05-17 at 01:56 +0100, M?ns Rullg?rd wrote:
>> Applied.
>> 
>> The semantics for extern inline are weird enough, and compiler broken
>> enough, that I'd rather not use it.
>
> Other functions in FFmpeg already rely on the "extern declaration in
> header + inline definition in one file" method to work with both
> compliant compilers and old GCC versions, for example ff_get_mb_score
> and ff_idct_xvid_sse2. That doesn't seem to be causing any problems. So
> I think there was little reason to add the renaming and indirection
> parts.

So change it if you're so damn smart.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list