[FFmpeg-devel] [PATCH] http Transfer-Encoding chunked

Peter Holik peter
Tue May 26 21:20:10 CEST 2009


>> documented and added a DEBUG statement for printing chunksize.

> Haha, almost correct:
>
> +#ifdef DEBUG
> +            printf("chunksize='%"PRId64"'\n", s->chunksize);
> +#endif
>
> printf() won't compile because of the define to please_use_av_log. So, please use av_log(). :-).
You can then also leave out the #ifdef DEBUG and just use av_log(context, AV_LOG_DEBUG (or so),
"Chunked encoding data size: %..", ..). Anyway, that's all I have, the patch looks good to me
otherwise, if the resubmitted one fixes the above, I'll apply in a few days unless somebody else
complains.

i used printf with DEBUG like i saw in http.c:

process_line

#ifdef DEBUG
        printf("http_code=%d\n", s->http_code);
#endif


http_connect

#ifdef DEBUG
            printf("header='%s'\n", line);
#endif


why now use av_log?


shall i change this printf's to av_log and remove DEBUG?

cu Peter






More information about the ffmpeg-devel mailing list