[FFmpeg-devel] [PATCH] http Transfer-Encoding chunked

Ronald S. Bultje rsbultje
Tue May 26 22:03:31 CEST 2009


Hi Peter,

On Tue, May 26, 2009 at 3:20 PM, Peter Holik <peter at holik.at> wrote:
> i used printf with DEBUG like i saw in http.c:
>
> process_line
>
> #ifdef DEBUG
> ? ? ? ?printf("http_code=%d\n", s->http_code);
> #endif
>
>
> http_connect
>
> #ifdef DEBUG
> ? ? ? ? ? ?printf("header='%s'\n", line);
> #endif
>
>
> why now use av_log?

That's a good catch. These lines of code are rather old, and most
likely predate the "forbidding" of printf(). They were not converted
for the simple reason that the compilation doesn't fail because DEBUG
is, by default, not included in CFLAGS. A separate patch which
converts them to av_log() at debugging-level would be much
appreciated. Alternatively, they could also be removed.

Ronald



More information about the ffmpeg-devel mailing list