[FFmpeg-devel] [PATCH] msrle move error check

Kostya kostya.shishkov
Wed May 27 06:56:25 CEST 2009


On Tue, May 26, 2009 at 09:00:57PM -0700, Baptiste Coudurier wrote:
> On 5/24/2009 12:43 AM, Baptiste Coudurier wrote:
> > Hi Kostya,
> > 
> > On 5/23/2009 11:25 PM, Kostya wrote:
> >> On Sat, May 23, 2009 at 10:59:58PM -0700, Baptiste Coudurier wrote:
> >>> Hi
> >>>
> >>> Patch moves error check where it is actually an error.
> >>> At the end of the last line (EOL), line == 0 and --line will make it -1.
> >> My proposal was to check two bytes of src[] in that condition - if they
> >> code end-of-picture, then it's fine, otherwise an error should be shown.
> >> There's no need to duplicate check IMO.
> > 
> > Good idea. Patch attached.
> > 
> 
> Kostya, how does it look ? :)

it looked fine to me
 
> -- 
> Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA



More information about the ffmpeg-devel mailing list