[FFmpeg-devel] [PATCH] msrle move error check

Baptiste Coudurier baptiste.coudurier
Wed May 27 08:44:04 CEST 2009


On 5/26/2009 9:56 PM, Kostya wrote:
> On Tue, May 26, 2009 at 09:00:57PM -0700, Baptiste Coudurier wrote:
>> On 5/24/2009 12:43 AM, Baptiste Coudurier wrote:
>>> Hi Kostya,
>>>
>>> On 5/23/2009 11:25 PM, Kostya wrote:
>>>> On Sat, May 23, 2009 at 10:59:58PM -0700, Baptiste Coudurier wrote:
>>>>> Hi
>>>>>
>>>>> Patch moves error check where it is actually an error.
>>>>> At the end of the last line (EOL), line == 0 and --line will make it -1.
>>>> My proposal was to check two bytes of src[] in that condition - if they
>>>> code end-of-picture, then it's fine, otherwise an error should be shown.
>>>> There's no need to duplicate check IMO.
>>> Good idea. Patch attached.
>>>
>> Kostya, how does it look ? :)
> 
> it looked fine to me
>  

Thanks, applied.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org



More information about the ffmpeg-devel mailing list