[FFmpeg-devel] [PATCH] use a single mpa_window for all mpa_synth users

[Reimar Döffinger]

On Sun, Oct 18, 2009 at 11:37:04PM +0200, Michael Niedermayer wrote:
> On Sun, Oct 18, 2009 at 02:44:11PM +0200, Reimar D?ffinger wrote:
> > Hello,
> > currently mpegaudiodec, qmd2 and mpc all duplicate the same 2kB data for the
> > mpa synthesis.
> > Attached patch just makes it use the same static variable in mpegaudiodec
> > and removes the function arguments for that.
> 
> dca does not use the same table

Well, it does not use those functions either.

> and i do have some unfinished and broken by other commits code that
> attempted to merge all that mess into a synth_filter.c with selectable
> int/float synth for mp3

Or is making the dca code use this part of your patch?

> > If you'd like to keep those function arguments I'd suggest to instead making
> > the variable globally visible and reusing it.
> 
> iam ok with that

Ok, I'll do it that way, I didn't know there might be uses for different windows.