[FFmpeg-devel] [PATCH] use a single mpa_window for all mpa_synth users
Mon Oct 19 15:42:47 CEST 2009
On Mon, Oct 19, 2009 at 08:47:38AM +0200, Reimar D?ffinger wrote:
> On Sun, Oct 18, 2009 at 11:37:04PM +0200, Michael Niedermayer wrote:
> > On Sun, Oct 18, 2009 at 02:44:11PM +0200, Reimar D?ffinger wrote:
> > > Hello,
> > > currently mpegaudiodec, qmd2 and mpc all duplicate the same 2kB data for the
> > > mpa synthesis.
> > > Attached patch just makes it use the same static variable in mpegaudiodec
> > > and removes the function arguments for that.
> > dca does not use the same table
> Well, it does not use those functions either.
> > and i do have some unfinished and broken by other commits code that
> > attempted to merge all that mess into a synth_filter.c with selectable
> > int/float synth for mp3
> Or is making the dca code use this part of your patch?
my patch factors the dca synth code out and tries to use it for mp3,
but as said its all uninished ...
ive not thought about using the mp3 code in dca, so i dont know how
hard that would be. But hardcoding the window seems wrong to me ...
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel