[FFmpeg-devel] [PATCH] improvement on r21598 ("fix stream copy")

Wolfram Gloger wmglo
Sat Feb 6 22:51:22 CET 2010


When using ffmpeg -t, after r21598:

+        /* finish if recording time exhausted */
+        if (pkt.pts * av_q2d(ist->st->time_base) >= (recording_time / 1000000.0))
+            goto discard_packet;

the test near line ffmpeg.c:2254: 

         /* finish if recording time exhausted */
         if (opts_min >= (recording_time / 1000000.0))

doesn't trigger anymore, because no packets with opts_min larger than
recording time are ever output (they are just discarded -- like they
should be).

So, everything still works correctly, but all input files are
needlessly read until EOF, and there are also timestamp discontinuity
warnings output every ten seconds.  How about the appended patch?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/octet-stream
Size: 1297 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100206/74c61744/attachment.obj>

More information about the ffmpeg-devel mailing list