[FFmpeg-devel] [PATCH] improvement on r21598 ("fix stream copy")

Michael Niedermayer michaelni
Sun Feb 7 10:27:46 CET 2010

On Sat, Feb 06, 2010 at 09:51:22PM -0000, Wolfram Gloger wrote:
> Hi,
> When using ffmpeg -t, after r21598:
> +        /* finish if recording time exhausted */
> +        if (pkt.pts * av_q2d(ist->st->time_base) >= (recording_time / 1000000.0))
> +            goto discard_packet;
> the test near line ffmpeg.c:2254: 
>          /* finish if recording time exhausted */
>          if (opts_min >= (recording_time / 1000000.0))
>              break;
> doesn't trigger anymore, because no packets with opts_min larger than
> recording time are ever output (they are just discarded -- like they
> should be).

well, what you write is a rather terse analysis ...
because really the tests should match unless predicted and real timestamps
differ and of course ignoring the current rounding bug reimar is working on

anyway, with your patch the opts_min test should be redundant and could
be removed

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100207/8e3cdd0d/attachment.pgp>

More information about the ffmpeg-devel mailing list