[FFmpeg-devel] [PATCH]set lavf ident string globally
Thu Feb 11 08:24:53 CET 2010
On Wed, Feb 10, 2010 at 10:50:17PM +0100, Michael Niedermayer wrote:
> iam mildly against this patch.
> the libavformat ident string is very important for dealing with muxer bugs
> on the demuxer side in the future.
> Setting it outside the demuxer like this makes it much easier to
> break it somehow without us noticing
I disagree. it's all "maybe sometime in the future", afaik we don't do
any checking now and it doesn't look like we'll start anytime soon.
because of this, almost nobody cares if the ident string gets writting
correctly. e.g. the mp3 muxer writes it twice, once normally and once as
a TXXX frame. Justin noticed this a few months ago, yet nobody cared
enough to fix it.
with my patch it'd break when all other metadata writing breaks. IMO
people care more about writing metadata correctly, so it would get
noticed/fixed much faster.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel