[FFmpeg-devel] [PATCH]set lavf ident string globally

Michael Niedermayer michaelni
Sun Feb 14 11:29:17 CET 2010

On Thu, Feb 11, 2010 at 08:24:53AM +0100, Anton Khirnov wrote:
> On Wed, Feb 10, 2010 at 10:50:17PM +0100, Michael Niedermayer wrote:
> > 
> > iam mildly against this patch.
> > the libavformat ident string is very important for dealing with muxer bugs
> > on the demuxer side in the future.
> > Setting it outside the demuxer like this makes it much easier to
> > break it somehow without us noticing
> > 
> I disagree. it's all "maybe sometime in the future", afaik we don't do
> any checking now and it doesn't look like we'll start anytime soon.

grep '_build\W' libavcodec/*.c

> because of this, almost nobody cares if the ident string gets writting
> correctly. e.g. the mp3 muxer writes it twice, once normally and once as
> a TXXX frame. Justin noticed this a few months ago, yet nobody cared
> enough to fix it.

you can write it twice, not writing it is the problem

> with my patch it'd break when all other metadata writing breaks. IMO
> people care more about writing metadata correctly, so it would get
> noticed/fixed much faster.

does your patch change the regression test checksums?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100214/c621e4cd/attachment.pgp>

More information about the ffmpeg-devel mailing list