[FFmpeg-devel] [PATCH]set lavf ident string globally
Sun Feb 14 11:32:49 CET 2010
On Sun, Feb 14, 2010 at 11:29:17AM +0100, Michael Niedermayer wrote:
> On Thu, Feb 11, 2010 at 08:24:53AM +0100, Anton Khirnov wrote:
> > On Wed, Feb 10, 2010 at 10:50:17PM +0100, Michael Niedermayer wrote:
> > >
> > > iam mildly against this patch.
> > > the libavformat ident string is very important for dealing with muxer bugs
> > > on the demuxer side in the future.
> > > Setting it outside the demuxer like this makes it much easier to
> > > break it somehow without us noticing
> > >
> > I disagree. it's all "maybe sometime in the future", afaik we don't do
> > any checking now and it doesn't look like we'll start anytime soon.
> grep '_build\W' libavcodec/*.c
> > because of this, almost nobody cares if the ident string gets writting
> > correctly. e.g. the mp3 muxer writes it twice, once normally and once as
> > a TXXX frame. Justin noticed this a few months ago, yet nobody cared
> > enough to fix it.
> you can write it twice, not writing it is the problem
> > with my patch it'd break when all other metadata writing breaks. IMO
> > people care more about writing metadata correctly, so it would get
> > noticed/fixed much faster.
> does your patch change the regression test checksums?
that is of course if you
1. enable writing the string
2. take checksums
3. apply your patch
4. take second set of checksums
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel