[FFmpeg-devel] [PATCH] move sqv1, flv alignment hack to align_dimensions

Reimar Döffinger Reimar.Doeffinger
Sat Feb 27 21:15:39 CET 2010

On Sat, Feb 27, 2010 at 08:45:56PM +0100, Michael Niedermayer wrote:
> On Sat, Feb 27, 2010 at 08:35:26PM +0100, Reimar D?ffinger wrote:
> > On Mon, Feb 15, 2010 at 11:14:14PM +0100, Michael Niedermayer wrote:
> > > the align_dimensions() should return a stride align value too and that should
> > > be used. that is align_dimensions2()
> > > if bumping up w_align works too, then i dont mind at all but its a hack
> > > and we should at least document the exact meaning of align_dimensions
> > > returned values ...
> > 
> > Like attached maybe? I'd prefer not to deprecate align_dimensions, I think
> > it is more convenient to use for most...
> > (promised, I will run make test on it, but the compilation will take some time
> > to finish).
> i wonder if we should have luma_stride & chroma_stride? or linesize being a
> int[2] to get the api right this time and save us from a align_dimensions3()

I'd say almost certainly.
However, I suspect that I don't fully understand everything and so this (untested)
patch is quite likely to be buggy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: aligndim.diff
Type: text/x-diff
Size: 4751 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100227/067b3712/attachment.diff>

More information about the ffmpeg-devel mailing list