[FFmpeg-devel] [PATCH] move sqv1, flv alignment hack to align_dimensions
Sat Feb 27 21:47:27 CET 2010
On Sat, Feb 27, 2010 at 09:15:39PM +0100, Reimar D?ffinger wrote:
> On Sat, Feb 27, 2010 at 08:45:56PM +0100, Michael Niedermayer wrote:
> > On Sat, Feb 27, 2010 at 08:35:26PM +0100, Reimar D?ffinger wrote:
> > > On Mon, Feb 15, 2010 at 11:14:14PM +0100, Michael Niedermayer wrote:
> > > > the align_dimensions() should return a stride align value too and that should
> > > > be used. that is align_dimensions2()
> > > > if bumping up w_align works too, then i dont mind at all but its a hack
> > > > and we should at least document the exact meaning of align_dimensions
> > > > returned values ...
> > >
> > > Like attached maybe? I'd prefer not to deprecate align_dimensions, I think
> > > it is more convenient to use for most...
> > > (promised, I will run make test on it, but the compilation will take some time
> > > to finish).
> > i wonder if we should have luma_stride & chroma_stride? or linesize being a
> > int to get the api right this time and save us from a align_dimensions3()
> I'd say almost certainly.
> However, I suspect that I don't fully understand everything and so this (untested)
> patch is quite likely to be buggy.
we will find that out, feel free to commit after (compile&make test)
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel