[FFmpeg-devel] [PATCH] Upgrade qt-faststart to keep users from hurting themselves
Sun Jan 3 13:12:54 CET 2010
On Sat, Jan 02, 2010 at 07:39:36PM -0800, Mike Melanson wrote:
> The attached patch checks for the presence of -DHAVE_AV_CONFIG_H on the
> command line when compiling qt-faststart. This is a front-line defense
> against users attempting to manually compile it and getting it wrong
> most of the time (binary builds but runs incorrectly on 64-bit systems).
> I tried to be genuinely helpful with the message:
> error: #error Do not compile qt-faststart manually. After configuring
> FFmpeg, run 'make tools/qt-faststart'.
> I chose to check HAVE_AV_CONFIG_H because that option seems to always be
> there when the build system is in charge. I think this should solve most
> mysterious bug reports related to qt-faststart.
This is not a good solution. IIUC the problem is that qt-faststart
requires some definitions to be present on the command line in order
for some 64 bit code to be enabled in system headers.
If you wish for these definitions to be present always, adding them
manually sounds like a much more robust solution.
More information about the ffmpeg-devel