[FFmpeg-devel] [PATCH] Upgrade qt-faststart to keep users from hurting themselves

Mike Melanson mike
Sun Jan 3 04:39:36 CET 2010

The attached patch checks for the presence of -DHAVE_AV_CONFIG_H on the 
command line when compiling qt-faststart. This is a front-line defense 
against users attempting to manually compile it and getting it wrong 
most of the time (binary builds but runs incorrectly on 64-bit systems).

I tried to be genuinely helpful with the message:

error: #error Do not compile qt-faststart manually. After configuring 
FFmpeg, run 'make tools/qt-faststart'.

I chose to check HAVE_AV_CONFIG_H because that option seems to always be 
there when the build system is in charge. I think this should solve most 
mysterious bug reports related to qt-faststart.

     -Mike Melanson
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: qt-faststart-sane-building.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100102/2c9aed1a/attachment.txt>

More information about the ffmpeg-devel mailing list