[FFmpeg-devel] [PATCH] libavdevice: make device_try_init static

Diego Biurrun diego
Mon Jan 4 19:44:47 CET 2010


On Mon, Jan 04, 2010 at 06:32:16PM +0100, Luca Abeni wrote:
>
> On 03/01/10 12:55, Diego Biurrun wrote:
>> On Sun, Jan 03, 2010 at 11:45:28AM +0100, Luca Abeni wrote:
>>> On 02/01/10 10:44, Reinhard Tartler wrote:
>>>> $subj.
>>>
>>> Patch applied, thanks! BTW, do you have some automated scripts or tools
>>> for performing this kind of checks? It could be interesting to integrate
>>> them in FATE, or similar...
>>
>> -Wmissing-prototypes
>> -Wmissing-declarations
>
> Thanks for the information, this is very useful!
> What about adding those switches to ffmpeg compilation? I do not know  
> the build system very much, but I am wondering if the attached patch is  
> acceptable.

I played with it some time ago.  However, I still wonder what the
difference between both is.  Enlightenment welcome.

> I tested it, and it even produced some new warnings ;-)

Did you fix them? :)

Attached is a list of warnings produced by -Wmissing-prototypes.
They all look sensible.

Diego
-------------- next part --------------
libavfilter/defaults.c:26: warning: no previous prototype for ?avfilter_default_free_video_buffer?
libavdevice/alldevices.c:32: warning: no previous prototype for ?avdevice_register_all?
libavformat/utils.c:1195: warning: no previous prototype for ?av_read_frame_flush?
libavformat/utils.c:2713: warning: no previous prototype for ?ff_interleave_compare_dts?
libavformat/apetag.c:65: warning: no previous prototype for ?ff_ape_parse_tag?
libavformat/mov.c:406: warning: no previous prototype for ?mp4_read_descr?
libavformat/avc.c:26: warning: no previous prototype for ?ff_avc_find_startcode?
libavformat/avc.c:63: warning: no previous prototype for ?ff_avc_parse_nal_units?
libavformat/avc.c:82: warning: no previous prototype for ?ff_avc_parse_nal_units_buf?
libavformat/avc.c:96: warning: no previous prototype for ?ff_isom_write_avcc?
libavformat/rtpproto.c:57: warning: no previous prototype for ?rtp_set_remote_url?
libavformat/rtpproto.c:293: warning: no previous prototype for ?rtp_get_local_port?
libavformat/rtpproto.c:306: warning: no previous prototype for ?rtp_get_file_handles?
libavcodec/audioconvert.c:82: warning: no previous prototype for ?get_channel_name?
libavcodec/dsputil.c:2746: warning: no previous prototype for ?ff_put_cavs_qpel8_mc00_c?
libavcodec/dsputil.c:2749: warning: no previous prototype for ?ff_avg_cavs_qpel8_mc00_c?
libavcodec/dsputil.c:2752: warning: no previous prototype for ?ff_put_cavs_qpel16_mc00_c?
libavcodec/dsputil.c:2755: warning: no previous prototype for ?ff_avg_cavs_qpel16_mc00_c?
libavcodec/dsputil.c:2766: warning: no previous prototype for ?ff_put_vc1_mspel_mc00_c?
libavcodec/dsputil.c:2769: warning: no previous prototype for ?ff_avg_vc1_mspel_mc00_c?
libavcodec/imgconvert.c:450: warning: no previous prototype for ?ff_is_hwaccel_pix_fmt?
libavcodec/imgconvert.c:455: warning: no previous prototype for ?ff_set_systematic_pal?
libavcodec/imgconvert.c:494: warning: no previous prototype for ?ff_fill_linesize?
libavcodec/imgconvert.c:596: warning: no previous prototype for ?ff_fill_pointer?
libavcodec/imgconvert.c:968: warning: no previous prototype for ?ff_get_plane_bytewidth?
libavcodec/resample2.c:96: warning: no previous prototype for ?av_build_filter?
libavcodec/utils.c:748: warning: no previous prototype for ?av_get_bit_rate?
libavcodec/utils.c:1042: warning: no previous prototype for ?av_tempfile?
libavcodec/lpc.c:58: warning: no previous prototype for ?ff_lpc_compute_autocorr?
libavcodec/rdft.c:82: warning: no previous prototype for ?ff_rdft_calc_c?
libavcodec/msrledec.c:243: warning: no previous prototype for ?ff_msrle_decode?
libavcodec/ac3dec.c:656: warning: no previous prototype for ?ff_ac3_downmix_c?
libavcodec/atrac1.c:254: warning: no previous prototype for ?at1_subband_synthesis?
libavcodec/atrac.c:50: warning: no previous prototype for ?atrac_generate_tables?
libavcodec/atrac.c:81: warning: no previous prototype for ?atrac_iqmf?
libavcodec/cavsdsp.c:518: warning: no previous prototype for ?ff_cavsdsp_init?
libavcodec/eaidct.c:79: warning: no previous prototype for ?ff_ea_idct_put_c?
libavcodec/mlpdsp.c:60: warning: no previous prototype for ?ff_mlp_init?
libavcodec/mpegaudiodec.c:104: warning: no previous prototype for ?ff_region_offset2size?
libavcodec/mpegaudiodec.c:114: warning: no previous prototype for ?ff_init_short_region?
libavcodec/mpegaudiodec.c:128: warning: no previous prototype for ?ff_init_long_region?
libavcodec/mpegaudiodec.c:138: warning: no previous prototype for ?ff_compute_band_indexes?
libavcodec/mpegaudiodecheader.c:33: warning: no previous prototype for ?ff_mpegaudio_decode_header?
libavcodec/pngdec.c:136: warning: no previous prototype for ?ff_add_png_paeth_prediction?
libavcodec/qcelpdec.c:601: warning: no previous prototype for ?interpolate_lpc?
libavcodec/rv30dsp.c:254: warning: no previous prototype for ?ff_rv30dsp_init?
libavcodec/rv40dsp.c:287: warning: no previous prototype for ?ff_rv40dsp_init?
libavcodec/snow.c:1002: warning: no previous prototype for ?ff_spatial_dwt?
libavcodec/vc1dsp.c:615: warning: no previous prototype for ?ff_vc1dsp_init?
libavcodec/intrax8dsp.c:416: warning: no previous prototype for ?ff_intrax8dsp_init?
libavcodec/vorbis_dec.c:1408: warning: no previous prototype for ?vorbis_inverse_coupling?
libavcodec/h263_parser.c:29: warning: no previous prototype for ?ff_h263_find_frame_end?
libavcodec/x86/mlpdsp.c:176: warning: no previous prototype for ?ff_mlp_init_x86?
libavcodec/x86/idct_mmx_xvid.c:485: warning: no previous prototype for ?ff_idct_xvid_mmx?
libavcodec/x86/idct_mmx_xvid.c:508: warning: no previous prototype for ?ff_idct_xvid_mmx2?
libavcodec/x86/dsputil_mmx.c:1824: warning: no previous prototype for ?ff_put_cavs_qpel8_mc00_mmx2?
libavcodec/x86/dsputil_mmx.c:1827: warning: no previous prototype for ?ff_avg_cavs_qpel8_mc00_mmx2?
libavcodec/x86/dsputil_mmx.c:1830: warning: no previous prototype for ?ff_put_cavs_qpel16_mc00_mmx2?
libavcodec/x86/dsputil_mmx.c:1833: warning: no previous prototype for ?ff_avg_cavs_qpel16_mc00_mmx2?
libavcodec/x86/dsputil_mmx.c:1840: warning: no previous prototype for ?ff_put_vc1_mspel_mc00_mmx?
libavcodec/x86/dsputil_mmx.c:1843: warning: no previous prototype for ?ff_avg_vc1_mspel_mc00_mmx2?
libavcodec/x86/cavsdsp_mmx.c:445: warning: no previous prototype for ?ff_cavsdsp_init_mmx2?
libavcodec/x86/cavsdsp_mmx.c:461: warning: no previous prototype for ?ff_cavsdsp_init_3dnow?
libavcodec/x86/lpc_mmx.c:68: warning: no previous prototype for ?ff_lpc_compute_autocorr_sse2?
libavcodec/x86/snowdsp_mmx.c:26: warning: no previous prototype for ?ff_snow_horizontal_compose97i_sse2?
libavcodec/x86/snowdsp_mmx.c:215: warning: no previous prototype for ?ff_snow_horizontal_compose97i_mmx?
libavcodec/x86/snowdsp_mmx.c:438: warning: no previous prototype for ?ff_snow_vertical_compose97i_sse2?
libavcodec/x86/snowdsp_mmx.c:536: warning: no previous prototype for ?ff_snow_vertical_compose97i_mmx?
libavcodec/x86/snowdsp_mmx.c:849: warning: no previous prototype for ?ff_snow_inner_add_yblock_sse2?
libavcodec/x86/snowdsp_mmx.c:863: warning: no previous prototype for ?ff_snow_inner_add_yblock_mmx?
libavcodec/x86/vc1dsp_mmx.c:695: warning: no previous prototype for ?ff_vc1dsp_init_mmx?
libavcodec/x86/vp3dsp_mmx.c:87: warning: no previous prototype for ?ff_vp3_v_loop_filter_mmx2?
libavcodec/x86/vp3dsp_mmx.c:108: warning: no previous prototype for ?ff_vp3_h_loop_filter_mmx2?
libavcodec/x86/vp3dsp_mmx.c:335: warning: no previous prototype for ?ff_vp3_idct_mmx?
libavcodec/x86/vp3dsp_mmx.c:386: warning: no previous prototype for ?ff_vp3_idct_put_mmx?
libavcodec/x86/vp3dsp_mmx.c:392: warning: no previous prototype for ?ff_vp3_idct_add_mmx?
libavcodec/x86/vp3dsp_sse2.c:158: warning: no previous prototype for ?ff_vp3_idct_sse2?
libavcodec/x86/vp3dsp_sse2.c:176: warning: no previous prototype for ?ff_vp3_idct_put_sse2?
libavcodec/x86/vp3dsp_sse2.c:182: warning: no previous prototype for ?ff_vp3_idct_add_sse2?
libavutil/sha.c:332: warning: no previous prototype for ?av_sha1_init?
libavutil/sha.c:337: warning: no previous prototype for ?av_sha1_update?
libavutil/sha.c:342: warning: no previous prototype for ?av_sha1_final?
libswscale/swscale.c:3186: warning: no previous prototype for ?sws_dcVec?



More information about the ffmpeg-devel mailing list