[FFmpeg-devel] [PATCH] libavdevice: make device_try_init static

Luca Abeni lucabe72
Mon Jan 4 20:40:06 CET 2010

On 04/01/10 19:44, Diego Biurrun wrote:
> On Mon, Jan 04, 2010 at 06:32:16PM +0100, Luca Abeni wrote:
>> On 03/01/10 12:55, Diego Biurrun wrote:
>>> On Sun, Jan 03, 2010 at 11:45:28AM +0100, Luca Abeni wrote:
>>>> On 02/01/10 10:44, Reinhard Tartler wrote:
>>>>> $subj.
>>>> Patch applied, thanks! BTW, do you have some automated scripts or tools
>>>> for performing this kind of checks? It could be interesting to integrate
>>>> them in FATE, or similar...
>>> -Wmissing-prototypes
>>> -Wmissing-declarations
>> Thanks for the information, this is very useful!
>> What about adding those switches to ffmpeg compilation? I do not know
>> the build system very much, but I am wondering if the attached patch is
>> acceptable.
> I played with it some time ago.  However, I still wonder what the
> difference between both is.  Enlightenment welcome.

Eh... I was going to ask a similar question ;-)
I guess I need to read the C standard searching for the difference 
between function declarations and prototypes...

>> I tested it, and it even produced some new warnings ;-)
> Did you fix them? :)

I looked at them, and some of the warning looks trivial to fix (missing 
#includes, missing "static", etc...). I'll send patches (or directly 
apply the fixes, as people prefer) as soon as I'll have some time.


More information about the ffmpeg-devel mailing list