[FFmpeg-devel] [PATCH] Clean up ipv6 vs the udp protocol
Tue Jan 12 12:22:45 CET 2010
On Tue, 12 Jan 2010, Luca Abeni wrote:
> > We need struct ipv6_mreq also,
> Yes, but the part of code I was commenting does not require ipv6_mreq.
> So, I believe that particular "#if" can be removed (and the part requiring
> ipv6_mreq can remain under "CONFIG_IPV6_MULTICAST").
No, the #if can't be removed completely, that's the build failure that
Ronald pointed out as a problem in my first attempt to remove the ipv4
codepath in udp.c. It needs some check, at least for struct sockaddr_in6.
I'll be back with another attempt at this, soon.
> > But yes, we could switch to checking for individual types, instead. Then
> > we'd have to check for both "struct ipv6_mreq" and "struct sockaddr_in6"
> > (unless you assume ipv6_mreq implies sockaddr_in6). Do you prefer that?
> Yes, I believe this (checking for individual data types, and switching
> from "CONFIG_*" to "HAVE_*") would be the best solution.
Ok, I'll finish that one then.
More information about the ffmpeg-devel