[FFmpeg-devel] What is missing for working AVFMT_FLAG_NONBLOCK?

Ronald S. Bultje rsbultje
Sun Jan 17 19:42:54 CET 2010


Hi,

On Sun, Jan 17, 2010 at 12:27 PM, aviad rozenhek <aviadr1 at gmail.com> wrote:
>> not reviewable, mixes cosmetics & functional changes
>>
> the previous patch removed the the for(;;) which becomes unnecessary, that's
> why there's indentation changes.

the correct thing to do is to send two patches, one removing the for()
and 1 for reindenting.

1:
[..]
-   for(;;) {
     x;
     y;
-  }
[..]
2:
-    x;
+  x;
-    y;
+  y;

> attached is an updated patch that changes just one line, but leaves the
> redundant for loop block in place.

Is plain wrong, should be if (errno == -EAGAIN) in if (ret < 0).

Ronald



More information about the ffmpeg-devel mailing list