[FFmpeg-devel] [PATCH] Avoid setting a zero timebase denominator in rtpdec

Ronald S. Bultje rsbultje
Thu Jan 28 22:05:20 CET 2010


Hi,

On Thu, Jan 28, 2010 at 4:01 PM, Martin Storsj? <martin at martin.st> wrote:
> If trying to view an RTSP/RTP stream with an unsupported audio codec, the
> st->codec->sample_rate field is left at zero (since it is set in
> rtsp.c:145, only if a decoder was found). The zero sample rate propagates
> to the st->timebase.den field at rtpdec.c:313, leading to crashes due to
> division by zero when using such a time base.
>
> The attached patch avoids the crashes by not propagating a clearly
> erroneous sample rate and emits a warning message instead.

This is the same bug as:
http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-August/074943.html

I've been pushing for a solution but it's not really happening yet... :-(.

Ronald



More information about the ffmpeg-devel mailing list