[FFmpeg-devel] [PATCH] Avoid setting a zero timebase denominator in rtpdec

Martin Storsjö martin
Thu Jan 28 23:08:51 CET 2010


On Thu, 28 Jan 2010, Ronald S. Bultje wrote:

> On Thu, Jan 28, 2010 at 4:01 PM, Martin Storsj? <martin at martin.st> wrote:
> > If trying to view an RTSP/RTP stream with an unsupported audio codec, the
> > st->codec->sample_rate field is left at zero (since it is set in
> > rtsp.c:145, only if a decoder was found). The zero sample rate propagates
> > to the st->timebase.den field at rtpdec.c:313, leading to crashes due to
> > division by zero when using such a time base.
> >
> > The attached patch avoids the crashes by not propagating a clearly
> > erroneous sample rate and emits a warning message instead.
> This is the same bug as:
> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-August/074943.html
> I've been pushing for a solution but it's not really happening yet... :-(.

Ah, I see. Good that the issue is known, at least. I guess my fix doesn't 
add any more consensus at the moment. Patch dropped, for now...

// Martin

More information about the ffmpeg-devel mailing list