[FFmpeg-devel] [RFC] libavfilter audio framework - split patches
Wed Jul 14 16:51:19 CEST 2010
On Wed, Jul 14, 2010 at 04:45:39PM +0200, Michael Niedermayer wrote:
> On Tue, Jul 13, 2010 at 02:38:16AM -0700, S.N. Hemanth Meenakshisundaram wrote:
> > Stefano Sabatini wrote:
> >> On date Sunday 2010-07-11 16:47:21 +0200, Michael Niedermayer encoded:
> >>> On Sun, Jul 11, 2010 at 06:58:15AM -0700, S.N. Hemanth Meenakshisundaram
> >>> wrote:
> >>>> S.N. Hemanth Meenakshisundaram wrote:
> >>>>> I am sending out the working lavfi audio patches in the order Stefano
> >>>>> requested for easy committing.
> >>>> [...]
> >> OK I indeed have the same concerns. I see two ways for fixing this:
> >> implementing some form of heiry macros, *or* generalize the code.
> >> [...]
> >> The alternative may be to define and use an AVFilterBuffer, define
> >> avfilter_ref_buffer()/avfilter_unref_buffer(), and make each
> >> AVFilterPicRef and AVFilterPicSamples refer to such an
> >> AVFilterBuffer.
> >> The latter would break ABI/API, but that's maybe currently not a
> >> concern.
> >> Regards.
> > This is the avfilter.h changes that go with the generalizing patch sent
> > earlier for avfilter.c and formats,c
> > avfilter.h | 91 +++++++++++++------------------------------------------------
> > 1 file changed, 20 insertions(+), 71 deletions(-)
> > 3eefde1ede71765f45262c4c591562e0d84ae118 avfih_changes.diff
> doesnt apply to svn
to elaborate on this, we need patches that apply to svn.
you can send a patch series so that patch n depends on patches 0..n-1
to be applied before it.
but if patch x (x<n) is changed due to discussions all later patches
must be rebased on the new code. We dont apply bad patches and then
apply fixes on top.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel