[FFmpeg-devel] [PATCH] url_fskip: Warn if the url_fseek call failed

[Michael Niedermayer]

On Fri, Jul 16, 2010 at 10:19:42AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Fri, Jul 16, 2010 at 9:31 AM, Martin Storsj? <martin at martin.st> wrote:
> > $subj - url_fskip returns void at the moment, so if the wrapped url_fseek
> > call fails, at least tell the poor user that is debugging it what's going
> > wrong.
> 
> Sometimes the seek intentionally is wrong, e.g. if the demuxer tests
> if the protocol can seek to a particular position.
> 
> > Or would it be ok to change url_fskip to return int and pass the error
> > code through, and check for the errors in the individual demuxers?
> 
> Probably... Michael can make a call here, he's maintainer.

passing the error code through seems more correct

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100716/95fcdccd/attachment.pgp>