[FFmpeg-devel] [PATCH] url_fskip: Warn if the url_fseek call failed

[Martin Storsjö]

On Fri, 16 Jul 2010, Michael Niedermayer wrote:

> On Fri, Jul 16, 2010 at 10:19:42AM -0400, Ronald S. Bultje wrote:
> > Hi,
> > 
> > On Fri, Jul 16, 2010 at 9:31 AM, Martin Storsj? <martin at martin.st> wrote:
> > > $subj - url_fskip returns void at the moment, so if the wrapped url_fseek
> > > call fails, at least tell the poor user that is debugging it what's going
> > > wrong.
> > 
> > Sometimes the seek intentionally is wrong, e.g. if the demuxer tests
> > if the protocol can seek to a particular position.
> > 
> > > Or would it be ok to change url_fskip to return int and pass the error
> > > code through, and check for the errors in the individual demuxers?
> > 
> > Probably... Michael can make a call here, he's maintainer.
> 
> passing the error code through seems more correct

Ok, what about this one?

I guess changing the return value from void to int doesn't break ABI on 
any platform we care about?

// Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-url_fskip-Return-an-error-code-if-the-url_fseek-fail.patch
Type: text/x-diff
Size: 1412 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100716/e5a39633/attachment.patch>